Change the example with the "useless use of echo" and backticks

idank / explainshell

match command-line arguments to their help text

GNU General Public License v3.0

12.98k stars 778 forks source link

Change the example with the "useless use of echo" and backticks #293

Open Strahinja opened 2 years ago

Strahinja commented 2 years ago

One of the examples on the front page,

file=$(echo `basename "$file"`)

is using the deprecated backticks and "useless use of echo". As explainshell.com is likely to be used for learning shell, this potentially teaches those bad habits.

This PR changes the example to

name=$(printf "%s@%s" "$(id -nu)" "$(uname -n)")