idank / explainshell

match command-line arguments to their help text
GNU General Public License v3.0
12.98k stars 778 forks source link

feat: docker build workflow #308

Closed sammcj closed 1 year ago

sammcj commented 1 year ago

Tested here - https://github.com/sammcj/explainshell/actions/runs/3708331408

@idank

sammcj commented 1 year ago

@idank

idank commented 1 year ago

Looks great overall, left one minor comment. Thanks for contributing!

idank commented 1 year ago

Can you squash the commits please?

sammcj commented 1 year ago

Usually GitHub has the squash and merge when merging PRs?

If it's not showing up for some reason I'll do it in a few days as I'm away from my computer for the holidays.

idank commented 1 year ago

oh you're right, i haven't seen that before, merging!

happy holidays and thanks again

idank commented 1 year ago

It appears there's some breakage in the tests workflow, I couldn't find the cause at a quick glance, any idea what changed?

https://github.com/idank/explainshell/actions/runs/3771229887/jobs/6411513291#step:8:170