search

idanwe / accounts-password-client-side

Use Meteor's accounts-password package with meteor-client-side.
MIT License
13 stars 10 forks source link

Add types and update to 1.3.3 #8

Closed leonardobazico closed 7 years ago

idanwe commented 7 years ago

@leonardobazico thank you very much! I think it is needed to update accounts-base-client-side too, Would you be able todo it?

leonardobazico commented 7 years ago

Sure! It's my next step

On 13 Jan 2017, at 07:08, Idan Wender notifications@github.com wrote:

@leonardobazico thank you very much! I think it is needed to update accounts-base-client-side too, Would you be able todo it?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

idanwe commented 7 years ago

@leonardobazico at the next PR don't update the version. It's better for me todo it with the tags

idanwe commented 7 years ago

@phamtrong204 I need your permission to publish the package to npm under the name accounts-password-client-side and accounts-base-client-side can you at me as collaborator?

leonardobazico commented 7 years ago

@idanwe, I want do a similar repo for accounts-facebook, accounts-google, etc.

How you know what packages is necessary to concat in *.bundle.js?

in accounts-base you do:

cat "$PACKAGES_PATH/callback-hook.js" >> $OUTPUT_PATH/$NAME.bundle.js
cat "$PACKAGES_PATH/localstorage.js" >> $OUTPUT_PATH/$NAME.bundle.js
cat "$PACKAGES_PATH/accounts-base.js" >> $OUTPUT_PATH/$NAME.bundle.js

and in accounts-password:

cat "$PACKAGES_PATH/sha.js" >> $OUTPUT_PATH/$NAME.bundle.js
cat "$PACKAGES_PATH/srp.js" >> $OUTPUT_PATH/$NAME.bundle.js

Basic you see what the package import and what is not included in global-imports?

phamtrong204 commented 7 years ago

@idanwe I have add you to collaborators list of accounts-password-client-side and accounts-base-client-side

I have publish accounts-password-client-side with version 1.3.3 and 1.3.4. v1.3.4 is my mistake, there is no any change in this version, but i can unpublish this. I try:

npm unpublish accounts-password-client-side@1.3.4 -f

and get error:

npm ERR! unpublish Failed to update data
...
npm ERR! "accounts-password-client-side status = 403" : accounts-password-client-side

Unpublish it if you can, thankyou very much.

idanwe commented 7 years ago

@phamtrong204 @leonardobazico I couldn't publish v1.3.3 / v.1.3.4 so I publish the new version as 1.3.5

idanwe commented 7 years ago

@leonardobazico Regard releasing accounts-facebook, etc..

I described it at this comment at #2

And there was several discussions #2, #6, idanwe/meteorc-client-side#23,

There was a try to create accounts-facebook, But I don't now what is the status of the repo.