search

iddm / serde-aux

An auxiliary serde library providing helpful functions for serialisation and deserialisation for containers, struct fields and others.
MIT License
152 stars 26 forks source link

serde aux function to get names for fields as they are serialized #20

Closed ta32 closed 3 years ago

ta32 commented 3 years ago

from https://github.com/serde-rs/serde/issues/1110

Do you prefer a different method name?

I combined the function to get the field names from structs and enums so its easier to use. It was possible to use the wrong method for the type for the original implementation.

I will try address any comments.

iddm commented 3 years ago

There are some unsuccessful pipelines. I suggest you run cargo clippy and cargo fmt locally and that will help you solve everything easily.

ta32 commented 3 years ago

Sure, edits by maintainer is checked for this PR.

I didn't understand what you meant by the removing example colon so I left that to you, I saw it in other places? Feel free to make any more edits if you need to thanks :)

iddm commented 3 years ago

Sure, edits by maintainer is checked for this PR.

I didn't understand what you meant by the removing example colon so I left that to you, I saw it in other places? Feel free to make any more edits if you need to thanks :)

Yes, so in "cool" markdown, the colons after headers aren't welcomed, just a style. For example, here you won't see : after features or Optional features headers.

iddm commented 3 years ago

I'll merge once the checks are done. Thanks again!