search

ide / react-native-button

A button for React apps
MIT License
773 stars 129 forks source link

Adds loading prop #28

Closed alex-mcleod closed 8 years ago

alex-mcleod commented 8 years ago

When the loading prop is true, an activity indicator component will be rendered. This indicator can be styled and colored using the styleLoading and loadingColor respectively.

andrewljohnson commented 8 years ago

I'm not the author of this lib, but I'm not sure this would need to be part of the base library. The UIButton library on iOS has no built-in capability... maybe just subclass react-native-button in the project?

ide commented 8 years ago

I agree with @andrewljohnson's assessment -- better to compose components instead of growing their surface area when it's not too hard to do so.

alex-mcleod commented 8 years ago

Thanks for the feedback @andrewljohnson and @ide, I think that makes sense, I'll close this.