search

ide / react-native-button

A button for React apps
MIT License
773 stars 129 forks source link

Edited files in order to respect "ESLINT" rules #55

Closed luizguilhermefr closed 7 years ago

luizguilhermefr commented 7 years ago

Simple contribution by removing some trailing commas and semicolons, and also adding spaces between function parenthesis.

Eslint for React-Native: https://www.npmjs.com/package/eslint-plugin-react-native

ericvicenti commented 7 years ago

Sorry, this is not the code style we use in this project

Edit: oops, I thought this was the react-native repo. Carry on, I'll let others decide!

luizguilhermefr commented 7 years ago

Thanks. It isn't personal choice. It's just to avoid headaches in projects that use Eslint, like some of mine.

ide commented 7 years ago

Can you use https://github.com/exponent/eslint-config-exponent instead?

luizguilhermefr commented 7 years ago

Why not to use the proposed package? If this repository proposes to serve the community, then the most used library should be used.

ide commented 7 years ago

I don't agree with that. You're free to fork this repository if you feel strongly about it.