Fixed LDO Flow - Githubissues

harshkhandeparkar commented 5 months ago

Closes #264

Changes

[x] Changed the LDO_COMPARATOR_LATCH site to the double-height site unithvdbl provided by sky130hvl.
[x] Changed the PT_UNIT_CELL site to unithv from unithd, which is meant for sky130hd.
[x] Increased VREG voltage domain size by 1 micron on the x-axis on both sides. This prevents the core area rows from reaching the bottom (See Fig. 1 and Fig. 2)
[x] Fixed the LDO_COMPARATOR_LATCH placement position, which was wrong because of the MY (mirror along y-axis) orientation.
[x] Fixed the save_images.tcl script. The upstream ORFS changes were incorporated (same as #256).
[x] Update the placement density estimation formula since it doesn't work for some array size values. (See Fig. 5 for allowed and estimated placement densities) [Used a dataset of median allowed place density]
[x] Fix DRC issues
[x] Fix the LVS trim pin mismatch issue
[x] Changed the prePEX netlist PFETs to high voltage PFETs to match the layout.
[ ] Update documentation

Context

Figure 1

Floorplan without increasing VREG domain size. Rows are colored in green.

Figure 2

Floorplan after increasing VREG domain size. Rows, colored in green, do not extend to the bottom near the edges.

Figure 3

Final output for array size = 129 (load current = 10mA) and placement density = 0.6.

Figure 4

Final output for array size = 13 (load current = 1mA) and placement density = 0.35.

Figure 5

Allowed Place Densities Allowed (ie, with the placement converging) place densities, estimated placement density according to the current formula, and median allowed densities.

msaligane commented 3 months ago

@harshkhandeparkar any plans to finish this PR?

harshkhandeparkar commented 3 months ago

@harshkhandeparkar any plans to finish this PR?

Juan was working on fixing the layout/LVS issues. Once they are fixed, this PR might be good to go.

chetanyagoyal commented 2 weeks ago

is this ready for review @harshkhandeparkar

harshkhandeparkar commented 2 weeks ago

is this ready for review @harshkhandeparkar

Yes.