Modified hardcoded PDK path with the environment variable PDK_ROOT in sky130_mapped.py

idea-fasoc / OpenFASOC

Fully Open Source FASOC generators built on top of open-source EDA tools

https://openfasoc.readthedocs.io

Apache License 2.0

216 stars 90 forks source link

Modified hardcoded PDK path with the environment variable PDK_ROOT in sky130_mapped.py #325

Open iitkgpshubham opened 4 days ago

iitkgpshubham commented 4 days ago

Modified hardcoded PDK path with the environment variable PDK_ROOT in sky130_mapped.py
PDK_ROOT also exist in docker installation, see Line 25 docker/conda/Dockerfile ENV PDK_ROOT=/usr/bin/miniconda3/share/pdk/
PDK_ROOT also created in Line 305 dependencies.sh export PDK_ROOT=/home/$(logname)/miniconda3/share/pdk/
PDK_ROOT variable is also used by other open source tools

iitkgpshubham commented 1 day ago

@msaligane @chetanyagoyal The test are failing ImportError: numpy.core.multiarray failed to import. I can see that tests uses numpy 2.0.0 Requirement already satisfied: numpy in /usr/bin/miniconda3/lib/python3.10/site-packages (from -r requirements.txt (line 3)) (2.0.0)

I use a version 1.26.4. I can see that docker also uses a same version. Please see if this can be used.

chetanyagoyal commented 1 day ago

@msaligane @chetanyagoyal The test are failing ImportError: numpy.core.multiarray failed to import. I can see that tests uses numpy 2.0.0 Requirement already satisfied: numpy in /usr/bin/miniconda3/lib/python3.10/site-packages (from -r requirements.txt (line 3)) (2.0.0)

I use a version 1.26.4. I can see that docker also uses a same version. Please see if this can be used.

We are handling this in a separate PR

iitkgpshubham commented 1 day ago

@chetanyagoyal please see if the new changes makes sense. However it is expected that PDK_ROOT variable gets created during installation...as docker installation does it.