ideaconsult / Toxtree.js

http://ideaconsult.github.io/Toxtree.js/

2 stars 3 forks source link

Do not show the deleted values in the final matrix #116

Closed vedina closed 9 years ago

vedina commented 9 years ago

112 correctly hides the deleted values , but it should only be done in the working matrix

The deleted values should not be visible in the final matrix.

gonzomir commented 9 years ago

Deleted data is not visible in the final matrix if it has been deleted before the final matrix is created. If it is deleted after the final matrix is created, this data is present in the final matrix because the final matrix is separate entity.

vedina commented 9 years ago

Even if present, the data flagged as "deleted" should not be visible in the final matrix (same as the old behaviour of both matrices)

gonzomir commented 9 years ago

It is not flagged as deleted because the final matrix is a snapshot of the working matrix before the data is deleted. Data in final matrix represents the state of the working matrix at the time it is created and later changes in the working matrix are not visible in any way in the final matrix. https://github.com/ideaconsult/Toxtree.js/issues/78#issuecomment-70408630

vedina commented 9 years ago

What is required is

if there are data entries flagged as deleted in the final matrix, they will not be shown.

Please confirm this is the behaviour.

gonzomir commented 9 years ago

This is the exact behaviour.

vedina commented 9 years ago

OK!

vedina commented 9 years ago

The server is modified to always send the working matrix, hence the content will always be the same, but the final matrix will hide the deleted values. #124