search

ideaconsult / Toxtree.js

http://ideaconsult.github.io/Toxtree.js/
2 stars 3 forks source link

Assessment report - empty substances #159

Closed vedina closed 8 years ago

vedina commented 8 years ago

Please fix the "null" strings

image

gonzomir commented 8 years ago

I can't replicate this bug, can you send me more info, please? A link to a bundle will be great.

vedina commented 8 years ago

bundle 9

gonzomir commented 8 years ago

This looks like duplicate of #139 and it is fixed in commit 9c9409e. Are these changes deployed?

vedina commented 8 years ago

139 is about the HTML rendering, it is indeed fixed. The changes are deployed. The screenshot above is from the DOCX report.

gonzomir commented 8 years ago

But the data for the DOCX is gathered from the rendered HTML, so if there are no "null" strings rendered, they should not appear in the report.

In the provided bundle example there are "null"s in the substance names.

Found the problem - it comes from commit 75fe90c.

vedina commented 8 years ago

ok, can you fix the new linkeddata function? We need the substance names to be linked to the study, not plain string as before.

gonzomir commented 8 years ago

The fix is in the default configuration on toxsubstance.js. Since we need the name to be linked, when it is null, we display a dash.