search

ideaconsult / Toxtree.js

http://ideaconsult.github.io/Toxtree.js/
2 stars 3 forks source link

Es6 promise polyfill and othe IE<11 shims #175

Closed gonzomir closed 8 years ago

gonzomir commented 8 years ago

Closes #172

Creating DOCX report requires Promise support, and the image plugin to the DOCX generation library also uses heavily Object.defineGetter, Object.__defineSetter and we need ArrayBuffer.slice to make image loading work. And all these are not natively supported in IE<11, so we need to add them.

vedina commented 8 years ago

Still doesn't work in IE

SCRIPT5009: 'Promise' is undefined
File: ui-matrix.js, Line: 841, Column: 11
gonzomir commented 8 years ago

Are you sure you are testing the right branch? There should be <script src="es6-promise.min.js"></script> in uses/ui-matrix-report.html on line 47: https://github.com/gonzomir/Toxtree.js/blob/es6-promise-polyfill/uses/ui-matrix-report.html#L47

vedina commented 8 years ago

I thought I did test the right branch. Tested again , within AMBIT, works OK!