ideaconsult / Toxtree.js

http://ideaconsult.github.io/Toxtree.js/
2 stars 3 forks source link

BaseURL fix attempt for Issue #183. #187

Closed thejonan closed 8 years ago

thejonan commented 8 years ago

I've made a small fix on image URL forming, that should fix it. I've also added a console log, telling us when a baseURL deduction has occurred. Please, let me know what it produced on this server.

Keep in mind that we have not yet decided the baseURL policy. For example loading from this URL: https://ambitlri.ideaconsult.net/ui/_search will make jToxKit think that https://ambitlri.ideaconsult.net/ui is the baseURL, because it cannot distinguish from https://ambitlri.ideaconsult.net/data/dataset/1, which will yield: https://ambitlri.ideaconsult.net/data as a baseURL.

Especially in the case images for dataset loading (i.e. jToxCompoung), it is not clear at all whether the images' names should be appended to:

vedina commented 8 years ago

Final fix for #183