Open uli-f opened 1 year ago
I followed here the same pattern from cdk-inchi where they use only one factory.
Thank you for the clarification!
I would like to leave this issue open for now and put the question to the CDK maintainers when this branch is ready for them to have a look. I am happy to put the work in if changes are necessary, this issue serves just as a reminder.
I am happy for you to apply any kind of tag (question, PR question, ...) to this and any other issues that we (or maybe that should read I 😃) want to clarify with the CDK maintainers.
The
RInChIGeneratorFactory
hands out three different objects:RinchiGenerator
,RinchiToReaction
andRinchiDecomposition
.This factory produces so much more than just 'RInChIGenerator'! 😃
I would like to either
Personally, I prefer Option 1, but I would very much like to hear your opinion here.