Splitting the Factory (or alternatively just renaming it)

ideaconsult / cdk

The Chemistry Development Kit

https://cdk.github.io/

GNU Lesser General Public License v2.1

0 stars 0 forks source link

Splitting the Factory (or alternatively just renaming it) #14

Open uli-f opened 1 year ago

uli-f commented 1 year ago

The RInChIGeneratorFactory hands out three different objects: RinchiGenerator, RinchiToReaction and RinchiDecomposition.

This factory produces so much more than just 'RInChIGenerator'! 😃

I would like to either

introduce different factories for the three type of object or just
rename to factory to something more general (RInChIFactory? RInChIProcessingFactory? ...?)

Personally, I prefer Option 1, but I would very much like to hear your opinion here.

ntk73 commented 1 year ago

I followed here the same pattern from cdk-inchi where they use only one factory.

uli-f commented 1 year ago

Thank you for the clarification!

I would like to leave this issue open for now and put the question to the CDK maintainers when this branch is ready for them to have a look. I am happy to put the work in if changes are necessary, this issue serves just as a reminder.

I am happy for you to apply any kind of tag (question, PR question, ...) to this and any other issues that we (or maybe that should read I 😃) want to clarify with the CDK maintainers.