search

ideaconsult / cdk

The Chemistry Development Kit
https://cdk.github.io/
GNU Lesser General Public License v2.1
0 stars 0 forks source link

Misc changes rinchigenerator #4

Closed uli-f closed 1 year ago

uli-f commented 1 year ago

This PR consists of two commits.

The first commit contains all the changes other than fixing the indentation.

The second commit only contains the changes to the indentation.

ntk73 commented 1 year ago

Merged only commit bcecf4e547c5e50c26af9d00b898a97a838e953a with conflict resolved due to previous changes in jna-rinchi (input parameters order change) as commit c7d0576b0a3d53f16749e0fefb2b5f2171dfea01. Commit 87c11ed743149285ea5beeb1801c4b7975440f33 is not applied currently because the changes and conflicts become too complex to track/figure out. I suggest to fix the formatting/indentation after finishing with java code and javadoc changes.

uli-f commented 1 year ago

Merged only commit bcecf4e with conflict resolved due to previous changes in jna-rinchi (input parameters order change) as commit c7d0576.

Thank you @ntk73.

Commit 87c11ed is not applied currently because the changes and conflicts become too complex to track/figure out. I suggest to fix the formatting/indentation after finishing with java code and javadoc changes.

Agreed.