search

ideaconsult / jna-inchi

Wrapper to access InChI from Java
GNU Lesser General Public License v2.1
0 stars 0 forks source link

Add test cases #10

Closed uli-f closed 1 year ago

uli-f commented 1 year ago

Please merge PR #3 into branch rinchi, then re-base on branch rinchi.

This should reduce this PR to the single commit 7fba15a32296a161dff9b02db92b6e139003d370.

uli-f commented 1 year ago

Rebased on rinchi branch.

Fixed assertions of error messages so that they are platform independent.

kerberizer commented 1 year ago

@uli-f Thank you very much again!

I'm afraid I might have not expressed well my idea in https://github.com/ideaconsult/jna-inchi/pull/3#issuecomment-1265391469 and it might've been confusing. Sorry! I meant to ask you to perform an interactive rebase so that we don't have those unnecessary merge commits from the main (in this case rinchi) branch polluting the commit history (we have some basic Git best practices that we follow here).

When opening several pull requests that are interdependent, it's okay to have each one branched out from the previous one (that we depend upon), but it's important to have a clean history without "reverse" merges, i.e. merges into the pull request from the branch that we later intend to merge the pull request into. This produces duplicated commits and it can get quite confusing.

Since #1 and #3 are now merged, we've (interactively) rebased this pull request again and opened it anew as #16 (which is the result that I hoped for—just the commits that are unique to the pull request), so that it can be easier to review.