search

ideaconsult / jna-inchi

Wrapper to access InChI from Java
GNU Lesser General Public License v2.1
0 stars 0 forks source link

MDLReactionWriter: removed method arguments in MDLReactionWriter that… #34

Closed uli-f closed 1 year ago

uli-f commented 1 year ago

… were always used with the same values and introduced static final Strings instead; added date and time to the header of output files in MDLReactionWriter; removed wrapper methods; moved JnaRinchiTest::readReactionFromResourceFile to class TestUtils to be able to re-use in MDLReactionWriterTest; added MDLReactionWriterTest and test files

ntk73 commented 1 year ago

@uli-f , I have already merged this PR and it is good that function readReactionFromResourceFile() is moved into a separate class. There is small question concerning the new class TestUtils: this class has no tests and this could be a problem for some automatic testing systems. I am wondering whether to put a dummy test in it? @vedina could you comment on this, please

uli-f commented 1 year ago

Thank you for merging Nikolay.

To the best of my knowledge not having any tests in a test class shouldn't be an issue. I would just move forward for now and keep this in mind. If anything pops up later we know where to look.