search

ideaconsult / jna-inchi

Wrapper to access InChI from Java
GNU Lesser General Public License v2.1
0 stars 0 forks source link

change class and method names conistently to camel case #38

Closed uli-f closed 1 year ago

uli-f commented 1 year ago

For example, MDLReactionReader -> MdlReactionReader getOldCTABChargeCoding -> getOldCtabChargeCoding and so on.

ntk73 commented 1 year ago

For example, MDLReactionReader -> MdlReactionReader getOldCTABChargeCoding -> getOldCtabChargeCoding and so on.

Generally I follow the camel case. These two examples are kind of exceptions since CTAB and MDL are well know formats. But anyway, I am OK with this.

uli-f commented 1 year ago

Generally I follow the camel case. These two examples are kind of exceptions since CTAB and MDL are well know formats. But anyway, I am OK with this.

Yes, you can see this both ways. I don't mind either way, so happy to just follow with whatever the guidelines are 😃

uli-f commented 1 year ago

@ntk73 As this change renames a few classes I'll do this once the other PRs are merged.

uli-f commented 1 year ago
ntk73 commented 1 year ago

@ntk73 As this change renames a few classes I'll do this once the other PRs are merged.

OK, PRs are merged you can go...

uli-f commented 1 year ago

Opened PR #45

ntk73 commented 1 year ago

PR #45 is merged and closed

dan2097 commented 1 year ago

For example, MDLReactionReader -> MdlReactionReader getOldCTABChargeCoding -> getOldCtabChargeCoding and so on.

Generally I follow the camel case. These two examples are kind of exceptions since CTAB and MDL are well know formats. But anyway, I am OK with this.

Just to add the camel case variant I've tried to follow is https://google.github.io/styleguide/javaguide.html#s5.3-camel-case I think the main advantage is that it's clearer in the case where a class name has two abbreviations right next to each other.

uli-f commented 1 year ago

Just to add the camel case variant I've tried to follow is https://google.github.io/styleguide/javaguide.html#s5.3-camel-case I think the main advantage is that it's clearer in the case where a class name has two abbreviations right next to each other.

Agreed. Classes such as MDLRXNWriter are definitely easier to read when written as MdlRxnWriter.