Closed uli-f closed 1 year ago
For example,
MDLReactionReader
->MdlReactionReader
getOldCTABChargeCoding
->getOldCtabChargeCoding
and so on.
Generally I follow the camel case. These two examples are kind of exceptions since CTAB and MDL are well know formats. But anyway, I am OK with this.
Generally I follow the camel case. These two examples are kind of exceptions since CTAB and MDL are well know formats. But anyway, I am OK with this.
Yes, you can see this both ways. I don't mind either way, so happy to just follow with whatever the guidelines are 😃
@ntk73 As this change renames a few classes I'll do this once the other PRs are merged.
CTabVersion
-> CtabVersion
MDLReactionReader
-> MdlReactionReader
MDLReactionReaderException
-> MdlReactionReaderException
MDLReactionUtils
-> MdlReactionUtils
MDLReactionWriter
-> MdlReactionWriter
MDLReactionReader
MDLReactionWriter
@ntk73 As this change renames a few classes I'll do this once the other PRs are merged.
OK, PRs are merged you can go...
Opened PR #45
PR #45 is merged and closed
For example,
MDLReactionReader
->MdlReactionReader
getOldCTABChargeCoding
->getOldCtabChargeCoding
and so on.Generally I follow the camel case. These two examples are kind of exceptions since CTAB and MDL are well know formats. But anyway, I am OK with this.
Just to add the camel case variant I've tried to follow is https://google.github.io/styleguide/javaguide.html#s5.3-camel-case I think the main advantage is that it's clearer in the case where a class name has two abbreviations right next to each other.
Just to add the camel case variant I've tried to follow is https://google.github.io/styleguide/javaguide.html#s5.3-camel-case I think the main advantage is that it's clearer in the case where a class name has two abbreviations right next to each other.
Agreed.
Classes such as MDLRXNWriter
are definitely easier to read when written as MdlRxnWriter
.
For example,
MDLReactionReader
->MdlReactionReader
getOldCTABChargeCoding
->getOldCtabChargeCoding
and so on.