create parent class for RinchiOutput // RinchiInputFromRinchiOutput // RinchiKeyOutput // FileTextOutput

ideaconsult / jna-inchi

Wrapper to access InChI from Java

GNU Lesser General Public License v2.1

0 stars 0 forks source link

create parent class for RinchiOutput // RinchiInputFromRinchiOutput // RinchiKeyOutput // FileTextOutput #5

Closed uli-f closed 1 year ago

uli-f commented 1 year ago

I would like to class probably named Output or similar that is a parent class for RinchiOutput , RinchiInputFromRinchiOutput, RinchiKeyOutput, FileTextOutput and extract shared members and methods of those classes to that parent class.

Shared members/methods:

private final int errorCode
private final String errorMessage

If the individual status classes are getting merged into a single class (see #6) this might sit in the parent class as well.

I am happy to re-factor this if you agree.

ntk73 commented 1 year ago

Yes, I agree. Having a common parent class is a good idea - the good practices according to OOP.

ntk73 commented 1 year ago

I have added a new class Output and moved in it the common stuff from classes RinchiOutput, RinchiInputFromRinchiOutput, RinchiKeyOutput, FileTextOutput and RinchiDecompositionOutput (all these are made descendants of Output)