search

ideacreation / react-native-barcodescanner

A barcode scanner component for react native - not maintained anymore - use react-native-camera
MIT License
537 stars 162 forks source link

Fix black screen bug by make CameraManager a singleton #61

Open jiaminglu opened 7 years ago

jiaminglu commented 7 years ago

Also removed a error log "Method called after release()" caused by calling stopCameraPreview twice

vysakh0 commented 7 years ago

@ideacreation If this PR is merged, it would be useful.

@jiaminglu Thank you for the PR, wondering how to use this into my project in case the PR is not yet merged. Should I copy the CameraManager.java file into android/app/src/main/java/com/myAppName/ ?

Scimonster commented 7 years ago

@vysakh0 I just added "react-native-barcodescanner": "jiaminglu/react-native-barcodescanner" to my package.json to use his fork.

vysakh0 commented 7 years ago

@Scimonster Thank you! Initially I used yarn, for some reason it didn't pull jiaminglu's code. So did a npm install and it worked.

knapeto commented 7 years ago

Can we marge it ?

HonzaMac commented 7 years ago

Are there any blockers, which prevent @andreaskeller from merging this PR and release this bug?