ideafast / ideafast-portal

Data platform and portal for the IDEAFast study
MIT License
1 stars 3 forks source link

Dmpplus/base ae lxd #2342

Closed wangjf8090 closed 2 weeks ago

wangjf8090 commented 6 months ago

Add: new LXD AE frontend and backend, (v0)

gitguardian[bot] commented 6 months ago

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [11372997](https://dashboard.gitguardian.com/workspace/25407/incidents/11372997?occurrence=139598146) | Triggered | Encrypted Private Key | f57100b97de3e5a6b622e6725ac4b79ae2dcb58b | packages/itmat-interface/config/config.sample.json | [View secret](https://github.com/ideafast/ideafast-portal/commit/f57100b97de3e5a6b622e6725ac4b79ae2dcb58b#diff-08cbb7e8f1898b6b3e8a70cb3fdeaa825dc8ff5336950ae6213ee604bb69fa08R69) | | [11025493](https://dashboard.gitguardian.com/workspace/25407/incidents/11025493?occurrence=135082482) | Triggered | Encrypted Private Key | fc3f8a8011cd08ef0e930e5ac32cb2f00f2cf97d | packages/itmat-interface/config/system.key | [View secret](https://github.com/ideafast/ideafast-portal/commit/fc3f8a8011cd08ef0e930e5ac32cb2f00f2cf97d#diff-352755952c23bdde221fd372c051055f6fc458537aa10fe0542dc86379e11aceR1) | | [9650369](https://dashboard.gitguardian.com/workspace/25407/incidents/9650369?occurrence=130031749) | Triggered | Company Email Password | d085ed31983524c30cd7b694fd20b4df99376d7a | packages/itmat-interface/config/config.sample.json | [View secret](https://github.com/ideafast/ideafast-portal/commit/d085ed31983524c30cd7b694fd20b4df99376d7a#diff-08cbb7e8f1898b6b3e8a70cb3fdeaa825dc8ff5336950ae6213ee604bb69fa08R57) | | [9650370](https://dashboard.gitguardian.com/workspace/25407/incidents/9650370?occurrence=130031750) | Triggered | Generic High Entropy Secret | d085ed31983524c30cd7b694fd20b4df99376d7a | packages/itmat-interface/config/init_config.mongodb.js | [View secret](https://github.com/ideafast/ideafast-portal/commit/d085ed31983524c30cd7b694fd20b4df99376d7a#diff-8e5f5b40789c791d44cd593886d0be4136b64d0d47e21681374f5c53d2b2684dR70) | | [11025493](https://dashboard.gitguardian.com/workspace/25407/incidents/11025493?occurrence=160809478) | Triggered | Encrypted Private Key | c8a3aab2361eead195b23d7efbcf2d497122b4be | packages/itmat-interface/config/system.key | [View secret](https://github.com/ideafast/ideafast-portal/commit/c8a3aab2361eead195b23d7efbcf2d497122b4be#diff-352755952c23bdde221fd372c051055f6fc458537aa10fe0542dc86379e11aceL1) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/specifics/private_key_encrypted#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

fguitton commented 5 months ago

But beyond that, please try to leave clean code behind you, don't commit unnecessary console.log and use the Logger class for printing. Don't comment code to leave it there, just delete it. As much as possible please avoid casting objects to : any this creates a lot of problems long term.

fguitton commented 2 weeks ago

To be respawn in a different PR