search

ideakid / sipdroid

Automatically exported from code.google.com/p/sipdroid
GNU General Public License v3.0
0 stars 0 forks source link

[PATCH] refactor contact_url creation #572

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
this patch introduces a private method for contact_url creation. this reduces 
some duplicated code. also this patch tries to make sure that no invald contact 
urls are being created. in the case of an already existing host part (ie. the 
realm), it is stripped before adding the IP address.

it would be great to see this in the repository. a patch review more than 
welcome.

thanks
kind regard
Thilo

Original issue reported on code.google.com by thilo.ba...@gmail.com on 27 Jul 2010 at 8:36

Attachments:

GoogleCodeExporter commented 9 years ago 
sorry, only know i notice:
this fixes the problem described in issue 521 and is therefore related to issue 
476.

Original comment by thilo.ba...@gmail.com on 28 Jul 2010 at 11:59

GoogleCodeExporter commented 9 years ago 
Would be nice to know which the better patch is.

Original comment by pmerl...@googlemail.com on 29 Jul 2010 at 10:54

GoogleCodeExporter commented 9 years ago 
my patch only fixes the problem for the contact_url - while the patch on bug 
476 is concerned about the same problem but for the to and from headers.

i'll add a comment on that bug in a minute...

Original comment by thilo.ba...@gmail.com on 30 Jul 2010 at 7:46

GoogleCodeExporter commented 9 years ago

Original comment by pmerl...@googlemail.com on 1 Sep 2010 at 12:27