Pause and wait not supported

[GoogleCodeExporter]

What steps will reproduce the problem?
1.Dial a number with a wait(;) or a pause(,)
2.
3.

What is the expected output? What do you see instead?
The same as when using the cell phone rather than sipdroid. Wait popup a box, 
pause will pause 2 seconds

What version of the product are you using? On what device/operating system?
1.5.5 beta
NexusOne froyo

Which SIP server are you using? What happens with PBXes?
Asterisk PBX

Which type of network are you using?
WiFi

Please provide any additional information below.
I don't think that this should be handle by your dial-plan.

Original issue reported on code.google.com by fred.nad...@gmail.com on 29 Jul 2010 at 11:11

[GoogleCodeExporter]

http://groups.google.com/group/sipdroid-users/browse_thread/thread/d1240933ee085
016/ac927481316215f6?lnk=gst&q=pause#ac927481316215f6

Original comment by pmerl...@googlemail.com on 27 Aug 2010 at 8:12

[GoogleCodeExporter]

My opinion is that the pause and wait symbol should be handle by SipDroid and 
not the PBX. I guess most people that use the function already have some 
contact with it. It works well for company that uses extensions.

My point of view is that this should be compatible with the regular dialer so 
that we don't have to store contact with extentions with two phone number, one 
being 123456789,,1234 and the other 1234567890p1234. 

I'll take a look at the source and see if I can suggest anything.

Original comment by fred.nad...@gmail.com on 27 Aug 2010 at 12:32

[GoogleCodeExporter]

I made a few modification to sipDroid. Well, after I figured out how to compile 
it, was a bit more complicated than the HelloWorld app.

My version handle both email address and phone number. Email address are passed 
directly like in version 1.5.5. As for now, phone number are dialled as 
intended but the post dialling option(',' ';' and any extension) are simply 
scraped. 

At least for now I can call my friends office using the contact entry, I simply 
just have to enter the extension by hand.

I'll check to have the pause, wait handle properly. It might take me a while.

Original comment by fred.nad...@gmail.com on 27 Aug 2010 at 10:20

[GoogleCodeExporter]

I have the pause working. So basically, dialing 5141234567,,1234 will dial at 
first 5141234567 and four second after the other hand answer, it will send 1234 
the same way as if you add press it from the keyboard.

The wait(;) is not implemented as I'm know sure what is the best way to do it.

I'll post the code if anyone's interested.

Original comment by fred.nad...@gmail.com on 28 Aug 2010 at 9:27

[GoogleCodeExporter]

Yes, please.

Original comment by pmerl...@googlemail.com on 28 Aug 2010 at 10:33

[GoogleCodeExporter]

Sorry, there is a lot of garbage in the diff. Eclipse remove the thrailling 
space, no big deal.

Works for me :)

Original comment by fred.nad...@gmail.com on 28 Aug 2010 at 11:28

Attachments:

• sipdroid.diff
• PostDialler.java

[GoogleCodeExporter]

1) Please clean up the garbage.

2) The code in PostDialler seems to mostly be a copy of the same code in 
another class. It would be better to integrate them into a single code base, 
subroutine, whatever.

Thanks for working on a second revision to get ready for checking in!

Original comment by pmerl...@googlemail.com on 30 Aug 2010 at 7:13

• Changed state: FutureRelease

[GoogleCodeExporter]

Here is a simpler implementation.

Tell me if you like it, then I'll see what I can do for the wait(;) part.

Regards

Original comment by fred.nad...@gmail.com on 7 Sep 2010 at 2:09

Attachments:

• sipdroid.diff

[GoogleCodeExporter]

This patch adds pause and wait support. Some translations(localization) were 
made for the languages that I understand(zh as an example is beyond my 
understanding).

Runs on my Nexus One with Froyo stock.

Please test the feature and report any unexpected behaviour.

Best regards

Original comment by fred.nad...@gmail.com on 9 Sep 2010 at 9:32

Attachments:

• sipDroid_res.diff
• sipDroid_src.diff

[GoogleCodeExporter]

Thanks for your patch. I've added you as a project member to check it in.

Original comment by pmerl...@googlemail.com on 17 Sep 2010 at 8:01

[GoogleCodeExporter]

Hi Fred,
I have applied the patch and compiled latest revision. I have found two issues. 
Maybe they are connected. When receiving the first call after starting Sipdroid 
the application somehow crashes after accepting the call. I can see the 
incoming call still in the status bar (call timer counting up) and Sipdroid is 
kind of running. I'm getting those pop up to "force shutdown" the app. On the 
Caller side the connection is not terminated but I can not her anything. 
Placing a short call on the Sipdroid phone and hanging up again, Sipdroid is 
returning to normal operation. Afterwards I can receive normal calls.
The second issue is a problem after having placed a call with some post dial 
options. When now an incoming call is received and accepted, I can hear the 
DTMF tones that were send in the earlier outgoing call again. And this does 
happen for all incoming calls from now on.

Br
Michael

Original comment by michael....@gmail.com on 19 Sep 2010 at 2:49

[GoogleCodeExporter]

Hi again,
by setting "public static String postDialOption;" to "public static String 
postDialOption = "";" I can eliminate the app crash.

The other problem occurs every time the In Call Screen is shown. If I activate 
the screen of my Milestone again during a call, the tones are sent. So it is 
easily reproducable by just turning off and on the screen.

Br
Michael

Original comment by michael....@gmail.com on 19 Sep 2010 at 6:46

[GoogleCodeExporter]

Thanks for the comment. It is indeed something I haven't test as I receive very 
few (read no) calls. I've isolated the issue and will post a fix shortly.

Thanks again for testing.

Original comment by fred.nad...@gmail.com on 20 Sep 2010 at 5:14

[GoogleCodeExporter]

Hi Fred,
were you already able to fix the issue? I would be interested in the fix.

@pmerle71
As the status is "Future Release": When do you plan to integrate this feature 
into the official release?

Br
Michael

Original comment by michael....@gmail.com on 15 Oct 2010 at 11:35

[GoogleCodeExporter]

Still not working in v2.0.1

Original comment by suka...@gmail.com on 18 Nov 2010 at 10:44

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

In 2.0.1 Pause works, but the call can't be resumed. When I try to resume it 
goes on crash on Galaxy S

Original comment by fabio.an...@gmail.com on 18 Nov 2010 at 11:14

[GoogleCodeExporter]

Issue 836 has been merged into this issue.

Original comment by pmerl...@googlemail.com on 3 Feb 2011 at 3:05

[GoogleCodeExporter]

Hi,

  I am having a similar issue, but this is coupled with Google voice.  What I am trying to do is this:

I have sipdroid connected to GV via pbxes.org.  I am trying to make an 
international call, which requires me to dial a local number followed by a 
"pause" followed by a PIN, another "pause" and then the actual international 
number.  If I get Sipdroid to dial the local access number [local access number 
is stored as (xxx) xxx - xxxx], I can then use the dialpad to enter the rest of 
the information and everything works; however, this gets annoying if the call 
does not go through and one has to redial etc.  If I try to store all the 
pieces of information (with "," denoting a pause), then I get an invalid number 
message.  It would be great if there is a way to store all the information with 
the required pauses/waits.

My Setup:

Android 2.2.1 on LG Optimus-V
Sipdroid 2.1 beta
GV

Regards,

Sree

Original comment by sreeniv...@gmail.com on 3 Mar 2011 at 4:00

[GoogleCodeExporter]

Original comment by pmerl...@googlemail.com on 31 Mar 2011 at 2:22

• Changed state: Started