idealista / prom2teams

prom2teams is an HTTP server built with Python that receives alert notifications from a previously configured Prometheus Alertmanager instance and forwards it to Microsoft Teams using defined connectors

Apache License 2.0

268 stars 84 forks source link

Bugfix/307 Fix replace_config to read prom2teams config #316

Closed santi-eidu closed 1 year ago

santi-eidu commented 1 year ago

Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions
Remember to set idealista:develop as base branch;

Description of the Change

After #307 in version 4.0.0 prom2teams config in docker volume returns an error. With tmp files you can control when to replace variables.

Benefits

Now you can add prom2teams config via volumen in docker.

Possible Drawbacks

N/A.

Applicable Issues

307

abdennour commented 1 year ago

then? what it will be reviewed ? BTW, are you bypassing error handling?!

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication