Several fixes - Githubissues

idealista / prom2teams

prom2teams is an HTTP server built with Python that receives alert notifications from a previously configured Prometheus Alertmanager instance and forwards it to Microsoft Teams using defined connectors

Apache License 2.0

274 stars 85 forks source link

Several fixes #345

Closed bgaillard closed 6 months ago

bgaillard commented 1 year ago

Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions
Remember to set idealista:develop as base branch;

Description of the Change

We encountered several problems with prom2teams recently and wanted to perform update in the project.

I observed several "small" problems after I first clone the project, here is a PR to fix those problems.

Remove double dist property in travis.yml
Fix bad Teams Client in README.md
Fix bad exception call with the MicrosoftTeamsRequestException class
Remove several unused imports
Fix error while installing pyyaml
Add clear message when docker-compose is not used.

Benefits

Just small fixes to allow ne proposing other improvement PRs after this one is merged.

Possible Drawbacks

Nothing, only bring fixes.

Applicable Issues

No issue opened.

stale[bot] commented 9 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.