fix: Make nested routes compatible with Feathers 3

idealley / feathers-hooks-rediscache

Set of caching hooks and routes for feathersjs.

MIT License

38 stars 12 forks source link

fix: Make nested routes compatible with Feathers 3 #22

Closed oppodeldoc closed 6 years ago

oppodeldoc commented 6 years ago

This commit updates the parseNestedPath function to account for new nested params in Feathers #3

See https://github.com/idealley/feathers-hooks-rediscache/issues/21

coveralls commented 6 years ago

Coverage remained the same at 74.884% when pulling 68b70b7d2df76332bcd05314ef6bfd43d2f8a15e on oppodeldoc:master into ef07b5139a39184fa09860374198718e39674710 on idealley:master.

oppodeldoc commented 6 years ago

@idealley Hey thanks so much for merging this in. I just pulled down 1.0.0 from NPM and it doesn't look like this change made it in there. Can you confirm? Maybe I'm wrong but I'm not seeing the change in what I pulled down into a fresh install.

idealley commented 6 years ago

That is weird.. Let me check

idealley commented 6 years ago

I am sorry. I merged very poorly. I do not even understand what I did. (I guess I was over worked). I hope this did not put you in any trouble or delay.

Sam

oppodeldoc commented 6 years ago

@idealley No problem, it's in there now! Thanks again for your responsiveness.