search

idealley / feathers-hooks-rediscache

Set of caching hooks and routes for feathersjs.
MIT License
38 stars 12 forks source link

fix default options #45

Closed SassNinja closed 6 years ago

SassNinja commented 6 years ago

I've worked over the default options management to make sure the options from the feathers config get always considered. The priority order is:

hook defaults < feathers config < hook (service) options

This PR is supposed to fix https://github.com/idealley/feathers-hooks-rediscache/issues/44

@idealley would you please review and let me know what you think abt it?

codecov[bot] commented 6 years ago

Codecov Report

Merging #45 into master will decrease coverage by 0.07%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
- Coverage   96.92%   96.85%   -0.08%     
==========================================
  Files           6        6              
  Lines         130      127       -3     
==========================================
- Hits          126      123       -3     
  Misses          4        4
Impacted Files Coverage Δ
src/hooks/cache.js 100% <100%> (ø) :arrow_up:
src/hooks/redis.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a4a6e31...2397ec9. Read the comment docs.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.3%) to 92.683% when pulling 2397ec90bde36ff71885768a18e6db5174cb163f on SassNinja:feature/fix-default-options into a4a6e3164c6d41900d02a38d7a4cf5b4ff41854f on idealley:master.

idealley commented 6 years ago

Thank you for the issue and the patch! I have just added a test and merged. NPM version will be published as soon as travis completes.

Sam