idealo / image-super-resolution

🔎 Super-scale your images and run experiments with Residual Dense and Adversarial Networks.
https://idealo.github.io/image-super-resolution/
Apache License 2.0
4.62k stars 762 forks source link

fixed bug where h5py downloads incompatible version of cython #249

Open heidenrei opened 9 months ago

heidenrei commented 9 months ago

h5py needs cython to compile. When cython is not installed on the machine it will automatically download cython to compile itself. Currently, the version of cython that it downloads is 3.0a1, which is unable to compile h5py. This bug is with h5py/cython and not directly stemming from image-super-resolution, but it is causing bugs downstream in this project. To fix this issue you just need to make sure that cython is installed on the machine first (with a compatible version). It would be good practice to include a specific version range in setup.py, but for now this works.

guy on h5py repo issues section discussing this solution