Use with(){} in src/base2/JSB/chrome/Rect.js

[GoogleCodeExporter]

If you're already rolling with with(this) dice in Rect.js, might as well go
all-in.

Original issue reported on code.google.com by jeresig on 18 Apr 2008 at 9:40

Attachments:

• Rect-with.js

[GoogleCodeExporter]

Hmm. This was supposed to be an enhancement, oops.

Original comment by jeresig on 18 Apr 2008 at 9:41

[GoogleCodeExporter]

You're right. I got so hyped by the "with" is evil argument that I forgot that 
it has
legitimate uses (like this example). Will fix. :)

Original comment by dean.edw...@gmail.com on 18 Apr 2008 at 11:43

• Changed state: Accepted
• Added labels: Module-base2.JSB

[GoogleCodeExporter]

Original comment by dean.edw...@gmail.com on 18 Apr 2008 at 11:44

• Added labels: Browser-All, Type-Enhancement
• Removed labels: Type-Defect

[GoogleCodeExporter]

Original comment by dean.edw...@gmail.com on 27 May 2008 at 12:20

• Changed state: Started

[GoogleCodeExporter]

Fixed in trunk:

http://base2.googlecode.com/svn/trunk/lib/

Original comment by dean.edw...@gmail.com on 27 May 2008 at 3:27

• Changed state: Fixed