idearium / eslint-config-idearium

Idearium ESLint config.
MIT License
0 stars 1 forks source link

Add package.json #1

Closed allanchau closed 7 years ago

allanchau commented 7 years ago

This is essentially the initial commit. Please review all files.

Setup

Testing

Notes

allanchau commented 7 years ago

@idearium/developers Finally ready for testing when you get a chance!

smebberson commented 7 years ago

@allanchau, could we update it be under the @idearium/eslint-config namespace rather than esling-config-idearium?

allanchau commented 7 years ago

@smebberson No sure why, but eslint say:

Make sure the module name begins with eslint-config-, such as eslint-config-myconfig.

http://eslint.org/docs/developer-guide/shareable-configs I think it may be used when you do "extends": "eslint-config-idearium" or "extends": "idearium"

smebberson commented 7 years ago

@allanchau, ah, okay. Do you know if we could use the @idearium namespace?

allanchau commented 7 years ago

@smebberson ah it worked! I just had to update the paths in browser.js and node.js.

allanchau commented 7 years ago

BTW the linter-eslint in atom seems to be a few versions behind (doesn't support AST selectors) so you will have to install a local copy of eslint when testing. I'll add this to the notes in the description.

allanchau commented 7 years ago

@idearium/developers I'm going to merge this in so we can start referencing the git repo rather than individual commits.