search

idearium / eslint-config-idearium

Idearium ESLint config.
MIT License
0 stars 1 forks source link

WIP: Codefresh #15

Closed allanchau closed 1 year ago

allanchau commented 6 years ago

This PR enables deployment via Codefresh.

Related PRs

allanchau commented 6 years ago

@smebberson This PR is ready for a quick review, but I'm not sure how to properly test it?

smebberson commented 6 years ago

@allanchau, do you mean test as in unit tests?

allanchau commented 6 years ago

@smebberson As in testing if a tagged commit will properly deploy it to production and if greenkeeper will update the lockfile when a package becomes out of date. I think we just have to wait until eslint or the comments plugin is updated to test greenkeeper?

allanchau commented 6 years ago

@smebberson If you haven't added the NPM token to the repo on codefresh I could also test it by doing an alpha tagged commit? As long as that fails at the deploy stage with some npm auth error we can assume it worked?