issues
search
ideas-lab-nus
/
epwshiftr
Create future EnergyPlus Weather files using CMIP6 data
https://ideas-lab-nus.github.io/epwshiftr/
Other
30
stars
7
forks
source link
joss-review pkg readme
#28
Closed
mitmat
closed
8 months ago
mitmat
commented
2 years ago
[ ] Missing statement of need.
[ ] Please consider adding an example on how to download the CMIP6 files, if you already have the URL and data directory (
https://github.com/ideas-lab-nus/epwshiftr#manage-cmip6-output-files
).
[ ] Also for the epw file, you can add the URL you gave me in
https://github.com/openjournals/joss-reviews/issues/4030#issuecomment-1011701997
I just saw, you have in the example section of
match_coord()
the code how to download an epw file. Maybe just put the same in the get started section.
[x] The contribute section needs to be improved. See also:
https://joss.readthedocs.io/en/latest/review_criteria.html#community-guidelines
You can also check how other packages in JOSS have dealt with this.
match_coord()
the code how to download an epw file. Maybe just put the same in the get started section.