Closed hongyuanjia closed 1 year ago
Merging #73 (0d0ff9c) into master (ce7dadb) will decrease coverage by
0.02%
. The diff coverage is99.71%
.
@@ Coverage Diff @@
## master #73 +/- ##
==========================================
- Coverage 99.82% 99.80% -0.03%
==========================================
Files 7 8 +1
Lines 1678 2005 +327
==========================================
+ Hits 1675 2001 +326
- Misses 3 4 +1
Impacted Files | Coverage Δ | |
---|---|---|
R/morph.R | 100.00% <ø> (ø) |
|
R/utils.R | 96.87% <92.30%> (-3.13%) |
:arrow_down: |
R/dict.R | 99.75% <100.00%> (+<0.01%) |
:arrow_up: |
R/esgf.R | 100.00% <100.00%> (ø) |
|
R/netcdf.R | 99.48% <100.00%> (ø) |
|
R/query.R | 100.00% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Pull request overview
This is a big PR with a lot of refactorings and new features.
EPWSHIFTR_ENV
tothis
.EsgfQuery
has been added to wrap the ESGF search RESTful APIs in a more flexible way. This allows to build a query in a step by step, e.g.query_esgf()$project("CMIP6")$activity_id("ScenarioMIP")$experiment_id(!"ssp126")$collect()
. This solves #63 and #65.EsgfQuery$new()
should beesgf_query()
. Unfortunately, this name has been taken.esgf_query()
has also utilized the new query URL encoding function. This solves #62. Note thatutils::URLencode()
is not used, since it also encodes other characters like!
,+
, etc.