search

ideasman42 / isect_segments-bentley_ottmann

BentleyOttmann sweep-line implementation (for finding all intersections in a set of line segments)
MIT License
91 stars 40 forks source link

added pip package data #22

Closed AND2797 closed 1 year ago

AND2797 commented 4 years ago

I have bundled all the required files in package_data required for uploading the package to PyPI. Suggest testing on PyPI test servers first.

ideasman42 commented 4 years ago

This is still adding a duplicate readme.rst, no files should be duplicated as result of supporting pip.

AND2797 commented 4 years ago

This is still adding a duplicate readme.rst, no files should be duplicated as result of supporting pip.

Got it, I will make a revision and push it for review.

AND2797 commented 4 years ago

I have pushed a new commit which only includes the required files.

ideasman42 commented 3 years ago

This pr still includes duplicate files & binary files.

ideasman42 commented 3 years ago

There are too many changes in this PR without any explanation.

Please submit smaller PR's that note what they do.

For example in setup.py

py_modules=['poly_point_isect'], is replaced by packages=["poly_point_isect"], - what does this fix?

I tested python setup.py install and it worked as expected.

Could you submit a new PR with only changes to include package_data, any other changes make separately with an explanation of what they do.