Closed AND2797 closed 1 year ago
This is still adding a duplicate readme.rst
, no files should be duplicated as result of supporting pip.
This is still adding a duplicate
readme.rst
, no files should be duplicated as result of supporting pip.
Got it, I will make a revision and push it for review.
I have pushed a new commit which only includes the required files.
This pr still includes duplicate files & binary files.
There are too many changes in this PR without any explanation.
Please submit smaller PR's that note what they do.
For example in setup.py
py_modules=['poly_point_isect'],
is replaced by packages=["poly_point_isect"],
- what does this fix?
I tested python setup.py install
and it worked as expected.
Could you submit a new PR with only changes to include package_data
, any other changes make separately with an explanation of what they do.
I have bundled all the required files in
package_data
required for uploading the package to PyPI. Suggest testing on PyPI test servers first.