search

ideawu / ssdb

SSDB - A fast NoSQL database, an alternative to Redis
http://ssdb.io/
BSD 3-Clause "New" or "Revised" License
8.19k stars 1.4k forks source link

Fix homebrew build #1381

Closed chenrui333 closed 3 years ago

chenrui333 commented 3 years ago

reverts #1374

ghen2 commented 3 years ago

Hi

This means that the original issue that https://github.com/ideawu/ssdb/pull/1374 intended to fix is now back:

If ssdb is installed by root, then an unprivileged user cannot run ssdb-cli because he has no privileges to write the .py/.pyc files generated from the .cpy code. root needs to invoke ssdb-cli at least once after installation, my change made this part of the Makefile build/install.

ideawu commented 3 years ago

Hi, I will add these to Makefile:

install:
    chmod 777 ${PREFIX}/_cpy_
ideawu commented 3 years ago

https://github.com/ideawu/ssdb/commit/61ae2cef97693a0fab9689883a1189900d99a21f

ghen2 commented 3 years ago

Ehh no, that is https://github.com/ideawu/ssdb/pull/1330 back again. You should never make executables world-writable, that is a serious security issue!

The py code needs to be generated just once, this should be done at build or install time, no later.

ghen2 commented 1 year ago

Can you please revert this chmod 777?