ideditor / schema-builder

🏗🏷 Create tagging schemas for iD
ISC License
12 stars 16 forks source link

Remove size from maki urls #119

Closed Cj-Malone closed 8 months ago

Cj-Malone commented 9 months ago

I'm a little lost, but I think I've found the right place.

This all started with a 404. Specifically id-tagging-schema references https://cdn.jsdelivr.net/gh/mapbox/maki/icons/toll-15.svg. Interestingly https://cdn.jsdelivr.net/gh/mapbox/maki/icons/toll.svg works. I checked a few other maki urls and the seem to work with both url formats, the images look the same to me, but aren't byte for byte the same. eg https://cdn.jsdelivr.net/gh/mapbox/maki/icons/shop-15.svg vs https://cdn.jsdelivr.net/gh/mapbox/maki/icons/shop.svg.

I've found my maki-toll, but no 15. Time to head up a level, and here we are.

But why are most of the 15s working?

It seems maki deprecated the 15 and 11 sizes in v7. The new icons only work on https://cdn.jsdelivr.net/gh/mapbox/maki/icons/animal-shelter.svg, not https://cdn.jsdelivr.net/gh/mapbox/maki/icons/animal-shelter-15.svg. My guess is the CDN still has old files on the old urls, with new files on the new urls.

So no icons from here will have any changes since pre v7, and new icons 404.

bhousel commented 9 months ago

JSDelivr CDN can support different kinds of links.

People should probably be using the /npm links instead of the /gh links for stable URLs.

Cj-Malone commented 9 months ago

And a specific version via github https://cdn.jsdelivr.net/gh/mapbox/maki@v8.0.0/icons/animal-shelter.svg. schema-builder would need to start tracking releases though.

Cj-Malone commented 9 months ago

Ping @tyrasd

Cj-Malone commented 8 months ago

Thank you :)