search

ideditor / schema-builder

🏗🏷 Create tagging schemas for iD
ISC License
12 stars 16 forks source link

add "secondary icon" property #135

Open tyrasd opened 5 months ago

tyrasd commented 5 months ago

Often, especially for relatively specific presets, it is hard to find a suitable icon which matches the preset perfectly. In many cases, these are presets which are a specific subtype of a more generic preset, let's take for example charging station for electric bicycles (from https://github.com/openstreetmap/id-tagging-schema/issues/1085): This could use the generic icon for charging stations as its main icon, but refine it by adding a secondary qualifier icon which represents the sub type. Here are some quick mockups of how it could look like in iD:


1ec5 commented 5 months ago

Do you envision name-suggestion-index presets also putting a badge on the main icon?

tordans commented 5 months ago

There are also the map pins to consider.

tyrasd commented 5 months ago

Do you envision name-suggestion-index presets also putting a badge on the main icon?

Yeah, this is a closely related consideration. I think it would make sense to show the brand icon similar to the secondary icons depicted above: this would make the type of map feature recognizable even if a user does not know a particular brand or when a brand operates different kind of facilities.

//edit: but note that this would not be affecting this repository, as it would not change the schema, and only be a change in how the client (e.g. iD) consumes and displays the icon.

tyrasd commented 5 months ago

There are also the map pins to consider.

Yes. But given that these have to be rendered pretty small, it is likely that the pins will continue to use just the primary icons.

1ec5 commented 5 months ago

I think it would make sense to show the brand icon similar to the secondary icons depicted above: this would make the type of map feature recognizable even if a user does not know a particular brand or when a brand operates different kind of facilities.

I could see this being useful particularly for NSI’s operator tree. After all, one can reasonably say, “This is a McDonald’s,” but not necessarily, “This is a National Park Service,” just based on who operates the POI. But one downside is that many brand icons are already difficult enough to recognize at the size used for primary icons, let alone when downsized to fit your mocked-up secondary icon box.

tyrasd commented 3 months ago

some additional cases of presets which could maybe make use of this feature: