search

ideditor / schema-builder

🏗🏷 Create tagging schemas for iD
ISC License
12 stars 16 forks source link

add colour field type #38

Closed k-yle closed 1 year ago

k-yle commented 2 years ago

Closes #26

Follow-up from https://github.com/openstreetmap/iD/pull/8782#discussion_r760094554

This means we can more reliably detect colour fields (e.g. building:colour=*, roof:colour=*), rather than the current logic in iD which would erroneoulsy match tags like seamark:buoy_cardinal:colour_pattern=*

tyrasd commented 2 years ago

Ah, one more thing. I overlooked that you chose the British spelling colour while one other field (localized) uses American spelling. I think it would probably be better if we remain consistent in that regard, wouldn't it?

//edit: Ah, wait. localized is also fine in British English. I must have remembered that one the wrong way around. Let's keep the spelling as is then. FWIW, the colour field in the presets repo also uses the BE spelling in the file name: https://github.com/openstreetmap/id-tagging-schema/blob/main/data/fields/colour.json

1ec5 commented 2 years ago

@tyrasd, this PR is approved, but only you are able to merge. Is there anything holding up a merge, such as needing to migrate id-tagging-schema’s roof:colour field back to the colour field type?