ideditor / schema-builder

🏗🏷 Create tagging schemas for iD
ISC License
12 stars 16 forks source link

Icons for field values #56

Closed 1ec5 closed 1 year ago

1ec5 commented 2 years ago

The field schema provides for an icon representing the field itself (for now: #30), but it has no way to indicate an icon for an individual option in a combobox or similar. In some cases, the individual values of a key would be more recognizable by a small pictogram than by a textual description. For example:

I’d recommend that these icons be used only in situations where they would make the name more easily understood, not for decorative purposes. The name would still be present, so downstream consumers wouldn’t be forced to display these icons, which might not be possible anyways in some contexts.

westnordost commented 2 years ago

I’d recommend that these icons be used only in situations where they would make the name more easily understood, not for decorative purposes

This criterium is a little fuzzy. What is considered as helpful for understanding differs from person to person. Do these help to understand the sport, the bridge structure, type of railway crossing, roof shape, italian police type, ... ? IMO yes, but whether one really needs an icon for "tennis" can be taken into question.

With no clear definition, it is either up to the individual maintainer (@tyrasd) to decide on a case-by-case basis or/and (experience tells me) that more and more unimportant icons will creep in over time. Whether this is a bad thing, I don't know, I am just saying that it is a new can of worms. It may help to at least at the beginning have a strict guideline what icons may be included and which not.

tyrasd commented 1 year ago

As a proof of concept, iD now supports tag-value icons for the crossing:markings tag / field (see https://github.com/openstreetmap/id-tagging-schema/pull/590). Example screenshot:

image

The implementation (see https://github.com/openstreetmap/iD/commit/ef044cd17d58419de59619ddefdf1fea842cdd98 and https://github.com/openstreetmap/iD/commit/62113dcf7429a6dea36df3c0236fcb0825ddbc8b) is still hardcoded for this specific field, but could relatively easily be later moved into the tagging schema.

tordans commented 1 year ago

As a proof of concept, iD now supports tag-value icons for the crossing:markings tag / field

I think that is a great idea and good solution that looks like something we would want as part of the schema so we can add more custom icons to more translated fields.

tyrasd commented 1 year ago

decide on a case-by-case basis or/and (experience tells me) that more and more unimportant icons will creep in over time.

I think we just have to see how popular this gets. I'd guess that iconography will almost always be of benefit, given that the chosen icons are good, which is IMHO the trickiest part here (e.g. due to the small size of the displayed icons). From my experience, people rarely have the time to put in extra effort to create acceptable icons for presets already (we use much too many generic icons for presets already, see https://github.com/openstreetmap/id-tagging-schema/issues/41), so I'd actually be quite happy if we saw more people interested in making good icons for this new feature.