search

ideditor / schema-builder

🏗🏷 Create tagging schemas for iD
ISC License
12 stars 16 forks source link

allow Röntgen icon set #75

Closed tyrasd closed 1 year ago

tyrasd commented 1 year ago

The Röntgen icon set includes some potentially quite useful icons for presets. For example:

Röntgen icons are licensed under a Creative Commons Attribution 4.0 International License.

westnordost commented 1 year ago

Err, where are the icons though? I didn't find them in the repo

tyrasd commented 1 year ago

Yeah, it's unfortunately not quite straight forward. Here's what I did for iD (https://github.com/openstreetmap/iD/commit/98e9a11a511179b24c8c0aa6f520a9ed372b1c55): install map-machine, then run map-machine icons to generate the individual icons, then take the icons_by_id version of the resulting output.

Alternatively, you could rely on iD's bundled copy at https://github.com/openstreetmap/iD/tree/develop/svg/roentgen – I will manually keep them up to date until a better solution is found.

//cc @enzet: It would be superbly nice to have a separate versioned package of just the pure icons, in order to use them more easily outside of map-machine. Do you think something like that would be feasible?

tordans commented 1 year ago

@tyrasd this reminds me of https://github.com/openstreetmap/id-tagging-schema/issues/314. Maybe this is a good reason to improve the documentation about how the whole icon stuff works from a dev but also from a content/"tagging"-contributor perspective.

westnordost commented 1 year ago

Alternatively, you could rely on iD's bundled copy at https://github.com/openstreetmap/iD/tree/develop/svg/roentgen – I will manually keep them up to date until a better solution is found.

Thanks!

tordans commented 1 year ago

FYI I created https://github.com/enzet/map-machine/issues/149 to track the issues of having the icons more easily consumed. I think there was no issue, yet, and it sounds like that really should be easier.