Rename `cycleway` to `directionalCombo`

tordans commented 1 year ago

Following the update in iD (https://github.com/openstreetmap/iD/pull/9423/files#diff-b3604385ed7e095c6c6fd1973a4c3d376f21e56f26452299a358d033411a38f6R65-R67) this changes the name of the field to make it reusable.

AFAIK this is all that needs to happen in this repo, right?

[ ] todo: Update version and date in Changelog.

Fixes https://github.com/ideditor/schema-builder/issues/79

tyrasd commented 1 year ago

Update version and date in Changelog.

I'll do this before I package this into a release.

tyrasd commented 1 year ago

FYI: in 2714c23, I tweaked this one last time:

directionalCombo field: split keys into key and keys

key is for the common version of the tag (e.g. *:both)

keys is for the directional subtags (e.g. *:left / *:right)

for example, this is how the cycleway field looks now:

{
    "type": "directionalCombo",
    "label": "Bike Lanes",
    "key": "cycleway",
    "keys": [
        "cycleway:left",
        "cycleway:right"
    ],
  …
}

This is to make the implicit distinction between the common and directional subtags a bit more explicit (compared to relying on implicit order in keys).

ideditor / schema-builder

Rename `cycleway` to `directionalCombo` #83