idefix-code / idefix

A fast finite volume code designed to run on many architectures, such as GPU, CPU and manycores, using Kokkos.
https://idefix.readthedocs.io/
Other
28 stars 19 forks source link

Simplify input file for DIMENSIONS < 3 setups #274

Closed glesur closed 3 weeks ago

glesur commented 1 month ago

Historically, Idefix has always required the user to specify the Grid and the boundary conditions in the 3 spatial directions regardless of the DIMENSIONS parameters. This has led to confusions a number of times for newcomers, since this is actually never used in practice.

This PR attempts at fixing this: we no longer require the Grid and Boundary conditions to be specified in the directions >= DIMENSIONS.

Tests with DIMENSIONS<3 have been adjusted accordingly.