idekerlab / dot-app

Cytoscape application for exporting to .dot file format
GNU General Public License v3.0
7 stars 4 forks source link

Arrow shapes are not exported to DOT #2

Closed keiono closed 7 years ago

keiono commented 9 years ago

Arrow shapes are not exported if they are set as Default.

Maybe this code helps to fix this issue:

https://github.com/cytoscape/cytoscape-impl/blob/develop/json-impl/src/main/java/org/cytoscape/io/internal/write/json/serializer/CytoscapeJsVisualStyleSerializer.java

mahermassoud commented 9 years ago

We are aware of this issue. It only applies to default target/head arrow shapes, not with default source/tail arrow shapes. We think it is because of an minor mistake in the source code here:

https://github.com/cytoscape/cytoscape-impl/blob/develop/ding-impl/ding-presentation-impl/src/main/java/org/cytoscape/ding/impl/DEdgeDetails.java

We think the error is on line 367. Compare it with the similar method on line 275.