search

idelse / idena-pocket

A web wallet for idena.
https://pocket.idena.dev
MIT License
11 stars 8 forks source link

Localization #24

Closed DevkoDev closed 4 years ago

DevkoDev commented 4 years ago

A way to translate the wallet in other languages will be helpful so all idena users can use the wallet

menxit commented 4 years ago

Uh! Localization it's something I'd like to avoid, but I know it could be a great improvement from a UX point of view. If someone want to implement this is welcome!

bingbinglee commented 4 years ago

I can attempt this.

menxit commented 4 years ago

I'm thinking that localization is something that introduce a lot of complexity in code and that we will must to maintain on new features released.

I'd like to use something like localizejs.com. It doesn't require to change code and offers an easy control panel to manage translations. However it costs a lot ($50/month, 2 languages and $275/month 5 languages). Do you know similar services but less expensive?

I don't want anyone wasting time in something that can be replaced by a service.

idenatoday commented 4 years ago

poeditor.com is free for open source projects and works great. Collaborative i18n, comments, exports as po/mo but also js or other formats.

menxit commented 4 years ago

Wow, great service! It seems requires more effort than localizejs, but it could be a good compromise.

bingbinglee commented 4 years ago

@menxit popeditor and i18n are almost similar in a way that they have similar level of complexity. popeditor lets to manage translations separately (and insert translations into the project during build) I guess from what i could sense from the glimpse of the blog, while i18n maintains a handmade collection of locale json inside the app directory which you can manually add to.

i18n seemed pretty okay since the main project also relies on the same for translations.

menxit commented 4 years ago

Uh, you are right. I thought poeditor let to update translations avoiding building process. Yep, I can confirm that this would be unuseful :/

bingbinglee commented 4 years ago

@menxit this work is done and en, hi translations are added in the PR to demonstrate how it works. https://github.com/idena-dev/idena-pocket/pull/29 Have a look when you can.

@ProjXDev if you would like to do Arabic translation, all translation files would be available in /public/locales/

DevkoDev commented 4 years ago

Hey i will do it soon when i get some free time 😀