search

iden3 / circom_old

Circuit compiler for zkSNARKs
GNU General Public License v3.0
471 stars 82 forks source link

MiMC compression function construct #29

Closed fredlacs closed 5 years ago

fredlacs commented 5 years ago

Hey there! Really cool project you've got going on here. Been playing around with the library lately and noticed some differences in the MiMC implementation compared to ethsnarks'. I made an issue there and got a great answer https://github.com/HarryR/ethsnarks/issues/119.

The MiMC implementation from @HarryR uses a different compression function, compared to circom's. I believe that circom's team can give a much better answer than me with regards to which one is more appropriate! The whole ecosystem can benefit from some standardisation :)

jbaylina commented 5 years ago

Answered in the other thread: https://github.com/HarryR/ethsnarks/issues/119#issuecomment-485234095