iden3 / circom_tester

Provides tools for testing circom circuits.
56 stars 28 forks source link

tester.js doesn't check circom2 #10

Open 0xPetra opened 2 years ago

0xPetra commented 2 years ago

Before creating a PR wanted to make sure I'm getting this correctly.

When using circom-hardhat both circom and circom2 are installed.

In tester.js it checks the compiler version above 2.0 against circom and it returns false. For this use case we could implement:

let output = (await exec('circom2 --version')).stdout;

instead of:

let output = (await exec('circom --version')).stdout;

Should we check circom2 version, and then if it fails we check circom to cover both cases?

ggomma commented 1 year ago

I hope this issue is solved.

It always return AssertionError: Wrong compiler version. Must be at least 2.0.0 error message for circom2.0 circuit

ggomma commented 1 year ago

I solved this issue by removing circom library from project.