iden3 / circom_tester

Provides tools for testing circom circuits.
56 stars 28 forks source link

Add 'isDefined' #7

Open mhgharieb opened 2 years ago

mhgharieb commented 2 years ago

'isDefined' is a function used by 'getDecoratedOutput'

mhgharieb commented 2 years ago

Also you must add const utils = require("./utils");

to wasm/tester.js and c/tester.js

alrubio commented 2 years ago

Thanks for the proposal, but I don't like to add the dependency to utiils.js and add there isDefined. I prefer to add it at the end of wasm/tester.js and remove utils. before its use. Do you want to change your PR? If so I'll accept it.

mhgharieb commented 1 year ago

@alrubio I made the changes as you suggested.