search

iden3 / circomlib

Library of basic circuits for circom
622 stars 212 forks source link

should nWindowsPerSegment be 62？ #12

Open zyfrank opened 5 years ago

zyfrank commented 5 years ago

https://github.com/iden3/circomlib/blob/d91afa804ace6481f4468eebc0bf55229771e24c/src/pedersenHash.js#L8

HarryR commented 5 years ago

Agreed, this should be 62. See: https://github.com/HarryR/ethsnarks/issues/121

jbaylina commented 5 years ago

In this version, I'm using a window size of 4 instead of 3. But it's better with 3 so this needs to be moved.