search

iden3 / circuits

Circom circuits used by the iden3 core protocol.
GNU General Public License v3.0
79 stars 14 forks source link

Review of circuits/idState.circom #6

Closed ed255 closed 4 years ago

ed255 commented 4 years ago

Here's a review of circuits/idState.circom.

Checking that newIdState != 0 is done twice: https://github.com/iden3/circuits/blob/512a451f6b1d9966fc6917ae130ef6f992485af7/circuits/idState.circom#L54-L57 https://github.com/iden3/circuits/blob/512a451f6b1d9966fc6917ae130ef6f992485af7/circuits/idState.circom#L64-L67

The rest looks good and matches the design we discussed!

arnaucube commented 4 years ago

true! fixed in #7 , using directly IsZero as IsEqual internally uses IsZero