search

iden3 / circuits

Circom circuits used by the iden3 core protocol.
GNU General Public License v3.0
81 stars 14 forks source link

Can the verifyCredentialSubject* templates be simplified to not use getClaimHeader()? #95

Closed nedgar closed 4 months ago

nedgar commented 1 year ago

The verifyCredentialSubject and verifyCredentialSubjectProfile templates use the getClaimHeader() template, but neither of its outputs are used, and it doesn't look like it adds any meaningful constraints. Is it required?

FYI @OBrezhniev

nedgar commented 1 year ago

Also wondering if the unused constraints would get optimized out.

OBrezhniev commented 1 year ago

We'll check. From circom perspective there's no notion of unused constraints. Compiler only distinguishes between linear and quadratic constraints, and can remove some linear ones.

OBrezhniev commented 4 months ago

Template rewritten