make identifier declaration of type `SchemaHash` consistent

iden3 / go-iden3-core

Go core implementation of the iden3 system

https://docs.iden3.io

Apache License 2.0

90 stars 33 forks source link

make identifier declaration of type `SchemaHash` consistent #429

Closed bajpai244 closed 1 year ago

bajpai244 commented 1 year ago

The identifiers of the type SchemaHash have different declarations in the file claim.go.

The following declarations exist as of now:

schemaHash: [1] [2] [3]
schema: [1]
sc: [1] [2]

This PR makes it consistent, by renaming all of these declarations to sh. The declarations mentioned above have a very short lifetime; hence, they have been renamed with the short name sh.

AndriianChestnykh commented 1 year ago

@bajpai244, the linter check failed. Try to apply this newer config to the workflow lint.yaml

  lint:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-go@v3
        with:
          go-version: 1.19.1
      - uses: golangci/golangci-lint-action@v3
        with:
          version: v1.49.0